advancedxy commented on code in PR #983:
URL: https://github.com/apache/iceberg-cpp/pull/983#discussion_r4226324436
##########
src/iceberg/expression/predicate.cc:
##########
@@ -267,13 +267,18 @@ Result<std::shared_ptr<Expression>>
UnboundPredicateImpl<B>::BindUnaryOperation(
if (!bound_term->MayProduceNull()) {
return Expressions::AlwaysFalse();
}
- // TODO(gangwu): deal with UnknownType
+ if (bound_term->type()->type_id() == TypeId::kUnknown) {
+ return Expressions::AlwaysTrue();
Review Comment:
unknown type is null default per iceberg spec:
https://iceberg.apache.org/spec/#primitive-types
`unknown_col is null` should produce true instead of false. This matches
iceberg-java's behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
