anuragmantri commented on PR #18401: URL: https://github.com/apache/iceberg/pull/18401#issuecomment-6068876252
Thanks @mxm and @pvary. I researched a bit more on the previous issues and PRs related to similar requests. I don't think this touches the spec. When the optional summary fields were standardized in #11660, they went into Appendix F as implementation guidance. @RussellSpitzer also asked to leave out anything tied directly to a table property (and see [this comment ](https://github.com/apache/iceberg/issues/16734#issuecomment-4660930711)in #16734 on keeping table properties out of the spec). Summary already carries keys that describe the writer or the table's state rather than the changes in that commit. For example, [Appendix F](https://iceberg.apache.org/spec/?h=f#other-fields) lists `engine-name` and `engine-version` under "Other Fields" alongside the WAP and cherry-pick markers. The keys this PR copies fall under that category of properties the table owner explicitly lists as describing the table, copied only by replace commits that don't change the table's data. Other implementations that don't support it will just drop the listed keys on replace, which is today's behavior. Also, `PyIceberg` and `iceberg-rust` don't produce replace commits yet IIUC. I'm still open to posting in @dev if you still think that is necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
