danielcweeks commented on code in PR #17918: URL: https://github.com/apache/iceberg/pull/17918#discussion_r4222350715
########## format/spec.md: ########## @@ -1511,6 +1544,7 @@ Maps with non-string keys must use an array representation with the `map` logica |**`variant`**|`record` with `metadata` and `value` fields. `metadata` and `value` must not be assigned field IDs and the fields are accessed through names. |Shredding is not supported in Avro.| |**`geometry`**|`bytes`|WKB format, see [Appendix G](#appendix-g-geospatial-notes)| |**`geography`**|`bytes`|WKB format, see [Appendix G](#appendix-g-geospatial-notes)| +|**`file`**|`record` with the `file` sub-fields. |See [File Type](#file-type). Avro has no `FILE` logical type; type identity comes from the Iceberg schema.| Review Comment: Why would we add that here? The field ids are already addressed in the table above? Why would we need to say that we need to assign them here? Do we do that for any other type? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
