sungwy commented on code in PR #18080:
URL: https://github.com/apache/iceberg/pull/18080#discussion_r4221240559
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1410,12 +1400,31 @@ paths:
- $ref: '#/components/parameters/prefix'
- $ref: '#/components/parameters/namespace'
- $ref: '#/components/parameters/table'
+ - $ref: '#/components/parameters/data-access'
post:
tags:
- Catalog API
summary: Remotely signs requests to object storage
operationId: signRequest
+ description: >
+ Signs one request to object storage on the client's behalf.
+
+
+ `RemoteSignResult` takes one of two forms, reported in
`signing-mechanism`. With
+ `remote-signing`, `headers` carries the signature. With
`remote-presigning`, `uri`
+ carries the signature.
Review Comment:
Yea I kept this as I think it is informational, and I think it's helpful to
distinguish why anyone server and client would want to support two different
modes with the same shape of the payload.
The point that @danielcweeks raised earlier was about the requirement to
have an empty header for `remote-presigning`. I agree with you folks on that
and I've already removed that requirement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
