mxm commented on code in PR #18406:
URL: https://github.com/apache/iceberg/pull/18406#discussion_r4220759671
##########
spark/v4.2/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##########
@@ -486,8 +486,10 @@ private String jobDesc(
private RewriteDataFiles.Result executeRemoveDanglingDeletes(
ImmutableRewriteDataFiles.Result rewriteResult) {
- RemoveDanglingDeletesSparkAction.Result result =
- new RemoveDanglingDeletesSparkAction(spark(),
table).toBranch(branch).execute();
+ RemoveDanglingDeletesSparkAction removeDanglingDeletesAction =
+ new RemoveDanglingDeletesSparkAction(spark(), table).toBranch(branch);
+ commitSummary().forEach(removeDanglingDeletesAction::snapshotProperty);
Review Comment:
This looks error-prone. Could we pass commitSummary() through a
RemoveDanglingDeletesSparkAction constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
