amogh-jahagirdar commented on code in PR #16294:
URL: https://github.com/apache/iceberg/pull/16294#discussion_r4220241366
##########
format/spec.md:
##########
@@ -966,6 +966,8 @@ A snapshot consists of the following fields:
| | | _required_ | **`added-rows`** |
The upper bound of the number of rows with assigned row IDs, see [Row
Lineage](#row-lineage) |
| | | _optional_ | **`key-id`** | ID
of the encryption key that encrypts the manifest list key metadata |
+In format version 4 and above, a snapshot's `timestamp-ms` must be strictly
greater than the `timestamp-ms` of its parent snapshot on the same branch. The
requirement applies only to snapshots committed while the table is at format
version 4 or higher; snapshots with no parent, and snapshots that existed
before a table was upgraded to v4, are not constrained.
Review Comment:
Maybe "Starting in v4, a snapshot's..."
and then for the final sentence "snapshots that were committed before a
table was upgraded to v4 or higher do not have this requirement"
##########
format/spec.md:
##########
@@ -1918,6 +1920,12 @@ Reading v4 metadata:
* Relative paths must be resolved against the table location before use (see
[Path Resolution](#path-resolution))
* When `location` is omitted, the table location must be provided (see [Table
Location Specification](#table-location-specification))
+Snapshot timestamp changes:
+
+* A snapshot's `timestamp-ms` must be strictly greater than the `timestamp-ms`
of its parent snapshot on the same branch.
+* The requirement applies only to snapshots committed while the table is at
format version 4 or higher.
Review Comment:
Not sure this needs to be said again, but if we do maybe there's a way to
combine it with the first sentence:
```
For snapshots committed while the table is at format version 4 or higher, a
snapshot’s timestamp-ms must be strictly greater than its parent snapshot’s
timestamp-ms on the same branch.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
