mxm commented on code in PR #18419:
URL: https://github.com/apache/iceberg/pull/18419#discussion_r4217865171
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/TableUpdater.java:
##########
@@ -107,7 +107,7 @@ private void findOrCreateBranch(TableIdentifier identifier,
String branch) {
try {
table.manageSnapshots().createBranch(branch).commit();
LOG.info("Branch {} for {} created", branch, identifier);
- } catch (CommitFailedException e) {
+ } catch (CommitFailedException | IllegalArgumentException e) {
table.refresh();
if (table.refs().containsKey(branch)) {
Review Comment:
NIT: It could help to check the table refs before refreshing the table. I
think the `IllegalArgumentException` can only happen when the table already has
the branch information from the `loadTable` call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
