fivetran-rahulprakash opened a new pull request, #18420: URL: https://github.com/apache/iceberg/pull/18420
`BigQueryMetastoreClientImpl` accepts `BigQueryOptions` but leaves outgoing requests at the HTTP client's 20-second defaults, ignoring any connect/read timeouts in the supplied options. This applies those timeout values in the existing request initializer while retaining the credential initialization, trusted transport, retry policy, and Iceberg error conversion. Negative values leave the HTTP-client defaults intact; zero retains its SDK meaning of no timeout. Plain `BigQueryOptions` currently supplies a 60-second read timeout, so honoring it changes BQMS reads from 20 to 60 seconds on that path. A package-private transport constructor (annotated `@VisibleForTesting`) enables deterministic request-level regression tests without external services, reflection, or private-field access. **Test plan:** verify configured/default/unset timeout behavior on table and dataset requests, SDK default vs. explicit-unset options, connect-only and read-only overrides, zero-forwarding, authentication header preservation, 409-to-`AlreadyExistsException` conversion, and no cross-client timeout leakage. --- **AI Disclosure** - Model: Claude Sonnet 4.6 (1M context) - Platform/Tool: Claude Code (Anthropic) - Human Oversight: [unknown - human to fill in] - Prompt Summary: Investigate BQMS timeout propagation in BigQueryMetastoreClientImpl and implement a minimal fix using a package-private transport-injection constructor with in-memory regression tests. Proposal, constructor sketch, regression-test plan, and implementation are AI-generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
