findinpath commented on code in PR #18359:
URL: https://github.com/apache/iceberg/pull/18359#discussion_r4219240121
##########
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##########
@@ -524,7 +527,8 @@ private static DeleteFile copyWithMinStats(DeleteFile file)
{
String referencedDataFile =
ContentFileUtil.referencedDataFileLocation(file);
if (referencedDataFile != null && file instanceof GenericDeleteFile) {
// a file-scoped position delete is matched by location and needs no
stats
- return ((GenericDeleteFile) file).copyWithoutStats(referencedDataFile);
+ String location =
referencedDataFiles.computeIfAbsent(referencedDataFile, key -> key);
Review Comment:
Is this optimization necessary?
if it is the same actual string path will there be two instances of it on
the heap?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
