YinZheng-Sun commented on code in PR #956:
URL: https://github.com/apache/iceberg-cpp/pull/956#discussion_r4216438049
##########
src/iceberg/data/file_scan_task_reader.cc:
##########
@@ -164,10 +165,21 @@ class FileScanTaskReader::Impl {
"Data file size must not be negative: {}",
data_file->file_size_in_bytes);
+ auto filter = task.residual_filter();
+ if (filter) {
+ ICEBERG_ASSIGN_OR_RAISE(auto is_bound, IsBoundVisitor::IsBound(filter));
Review Comment:
Updated IsBoundVisitor to use a tri-state result internally, following
Java’s handling of constants and predicate binding states. Constants return
std::nullopt, and combining bound and unbound predicates returns an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
