pbajpai21 commented on PR #18050:
URL: https://github.com/apache/iceberg/pull/18050#issuecomment-6052509286
@laskoviymishka Thanks for the careful review and the approval.
Addressed all three follow-ups in the latest commit
- loosened the two exception-message assertions to
`hasMessageContaining`(...)
- removed the now-redundant `serializeConfWithInvoked` flag and field, and
- renamed the default Hadoop test to
`hadoopConfigurableRoundTripUsesDefaultSerializableConfiguration` to flag that
it covers the `SerializableConfiguration::new` overload.
I really appreciate the thorough feedback across both rounds.
Please review the latest changes and If you find them in good and acceptable
shape, please merge the PR too. (I still don't have write access 😄 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
