ebyhr commented on code in PR #4088:
URL: https://github.com/apache/iceberg-python/pull/4088#discussion_r4213280156
##########
pyiceberg/view/__init__.py:
##########
@@ -30,16 +30,19 @@ class View:
_identifier: Identifier
metadata: ViewMetadata
config: dict[str, str]
+ metadata_location: str | None
Review Comment:
nit: The REST spec marks `metadata-location` as required, but `ViewResponse`
already makes it optional, so `str | None` is consistent. Could we document
when it's None?
##########
pyiceberg/view/__init__.py:
##########
Review Comment:
nit: `__eq__` ignores `metadata_location`. That seems intentional, but a
short comment saying so might be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
