Revanth14 commented on code in PR #2098:
URL: https://github.com/apache/iceberg-go/pull/2098#discussion_r4210993288
##########
catalog/rest/rest.go:
##########
@@ -1122,6 +1147,7 @@ func (r *Catalog) createSession(ctx context.Context, opts
*options) (*http.Clien
session.defaultHeaders.Set("Content-Type", "application/json")
session.defaultHeaders.Set("User-Agent", "GoIceberg/"+iceberg.Version())
session.defaultHeaders.Set(headerIcebergAccessDelegation,
defaultAccessDelegation)
+ session.builtinHeaders = session.defaultHeaders.Clone()
Review Comment:
Fixed in the previous push: `builtinHeaders` is built after the
`WithHeaders` / `header.*` loops. The override case is now covered in
`TestCredentialsNotSentCrossOrigin`, which fails if the copy is taken before
the overrides.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
