hcrosse commented on code in PR #2100:
URL: https://github.com/apache/iceberg-go/pull/2100#discussion_r4212068155
##########
table/transaction.go:
##########
@@ -867,7 +880,7 @@ func (t *Transaction) ExpireSnapshots(opts
...ExpireSnapshotsOpt) error {
updates = append(updates,
NewRemoveSnapshotsUpdate(snapsToDelete, cfg.postCommit))
}
- return t.apply(updates, reqs)
+ return t.applyPinned(updates, reqs, pinned)
Review Comment:
Applied your suggestion, thanks. Added a regression test for the no-op
expiry case.
##########
table/transaction.go:
##########
@@ -3368,6 +3381,9 @@ func (t *Transaction) Commit(ctx context.Context)
(*Table, error) {
if !errors.Is(err, ErrCommitFailed) {
t.committed = true
}
+ if errors.Is(err, ErrTransactionUnusable) {
+ t.unusable = true
+ }
Review Comment:
Updated the comment and added a transaction-level test for the append path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
