eneskeles commented on code in PR #2111:
URL: https://github.com/apache/iceberg-go/pull/2111#discussion_r4210215239
##########
table/transaction.go:
##########
@@ -2706,7 +2709,16 @@ func (t *Transaction)
classifyFilesForFilteredDeletions(ctx context.Context, fs
return nil, nil, nil, fmt.Errorf("failed to create inclusive
metrics evaluator: %w", err)
}
- strictEvaluator, err := newStrictMetricsEvaluator(schema, filter,
caseSensitive, false)
+ // A file is deleted as a whole only if the filter is true for all of
its
+ // rows. The strict evaluator treats predicates as two-valued, so
NotEqual
+ // and NotIn would also count rows where the filter is NULL. Evaluate
the
+ // negation of the rows the rewrite keeps instead, so that both paths
agree.
+ notTrue, err := isNotTrueExpr(filter)
+ if err != nil {
+ return nil, nil, nil, err
Review Comment:
I see, this ones wrapped too now in 2eed003e.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
