DerGut commented on code in PR #3081:
URL: https://github.com/apache/iceberg-rust/pull/3081#discussion_r4209460563
##########
crates/catalog/rest/src/auth/mod.rs:
##########
@@ -73,6 +75,26 @@ pub trait AuthManager: Debug + Send + Sync {
client: &HttpClient,
props: &HashMap<String, String>,
) -> Result<Arc<dyn AuthSession>>;
+
+ /// Returns the authentication session for a specific context.
+ ///
+ /// The catalog calls this method only after [`Self::catalog_session`] has
+ /// succeeded. `catalog_session` is the catalog session returned by this
+ /// manager. If the context does not require different authentication,
+ /// implementations should return `catalog_session` unchanged.
Review Comment:
The client reuse is already stated on the [`AuthManager`'s doc
comment](https://github.com/DerGut/iceberg-rust/blob/15ef053d8fc27de5258689ec8c9f05112737cd42/crates/catalog/rest/src/auth/mod.rs#L50-L55):
> ```rust
> /// [`Self::init_session`] and [`Self::catalog_session`] are handed the
> /// catalog's [`HttpClient`], which an implementation may reuse for its own
> /// requests (e.g. a token exchange) so that they share the catalog's
> /// connection pool and configuration.
> ```
I made both more specific in
https://github.com/apache/iceberg-rust/pull/3081/commits/9267df86a510ffca097b5991a691e907a26a6a42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
