kastoestoramadus opened a new pull request, #18409: URL: https://github.com/apache/iceberg/pull/18409
Closes #15916 After #15288 the "Writing to Branches" section of `docs/docs/spark-writes.md` no longer matched `SparkTableUtil.determineWriteBranch`. Before: the page said the target branch must always exist, and that a branch identifier and `spark.wap.branch` "cannot both be specified". After: - Spark 4.1+: documents the `branch` write option (must match the identifier branch if both are set), and that an explicit branch wins over the session WAP branch, which is used only when none is set and WAP is enabled. - Spark 3.5 and 4.0: documents that an explicit branch combined with `spark.wap.branch` still fails validation. - A branch named in the table identifier must exist; the session WAP branch and the `branch` option (4.1+) may create it during the write. - The WAP note now states the real constraint: WAP ID and WAP branch cannot both be set. Docs only, no test to write. `cd site && make build` (markdown lint + `mkdocs build`) passes. Generated with deepseek-4.1-flash/h through [Claude Code](https://claude.com/claude-code) Reviewed by sonnet-5.5/l -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
