Revanth14 commented on PR #2099: URL: https://github.com/apache/iceberg-go/pull/2099#issuecomment-6030240557
Thanks @zeroshade and @laskoviymishka for the reviews! I've addressed the remaining threads in the follow-up #2140: - end-to-end test pinning the `ErrCommitDiverged` abort when a concurrent commit already removed the same file - `slices.Concat` + `rewriteValidator(removed)` - neutral wording for the conflict error messages - releasing the test `TableReader` The equality-delete branch is already covered by `TestValidateNoNewDeletesForRewrittenFiles_EqDeleteAlwaysConflicts`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
