HuaHuaY commented on code in PR #952:
URL: https://github.com/apache/iceberg-cpp/pull/952#discussion_r4202716201
##########
src/iceberg/manifest/manifest_group.cc:
##########
@@ -211,40 +329,16 @@ class ManifestGroup::FilePlanningStream final : public
FileScanTaskStream {
private:
FilePlanningStream(std::unique_ptr<ManifestGroup> group,
std::unique_ptr<DeleteFileIndex> delete_index,
- std::unique_ptr<Evaluator> data_file_evaluator,
- std::vector<std::string> columns, bool drop_stats)
+ PlanningContext context, bool drop_stats)
: group_(std::move(group)),
delete_index_(std::move(delete_index)),
- data_file_evaluator_(std::move(data_file_evaluator)),
- columns_(std::move(columns)),
+ context_(std::move(context)),
drop_stats_(drop_stats) {}
using TaggedEntry = std::pair<int32_t, ManifestEntry>;
using TaggedStream = std::pair<int32_t, ManifestEntryStreamPtr>;
- // FIXME: Perhaps refactor this concurrent/sequential stream state machine
into a
Review Comment:
I restored the comments. Since this PR unifies the serial and parallel code,
I made some minor adjustments to the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
