YuangGao commented on PR #3179: URL: https://github.com/apache/iceberg-rust/pull/3179#issuecomment-6027884612
Rebased onto main — the S3 variant now carries `client_config` next to `multipart_part_size`, and the tests run against the RustFS fixture. - Ceiling lowered to i32::MAX, doc points to opendal.io-timeout-ms for slow links, and the S3Config gap is documented — details inline. - Error strings now derive their units from the consts. - Kept the named serde default: a plain #[serde(default)] on a bare u64 would deserialize older payloads to 0, which OpenDAL then raises to the 5 MiB floor, so the default would quietly drop from 32 MiB to 5 MiB. Happy to wrap it in a type if that's what you had in mind. - The S3 integration tests (now on RustFS rather than MinIO) are green on the rebased head. @laskoviymishka ready for another look, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
