mbutrovich commented on code in PR #3354:
URL: https://github.com/apache/iceberg-rust/pull/3354#discussion_r4198170160
##########
crates/iceberg/src/avro/schema.rs:
##########
@@ -254,11 +271,11 @@ impl SchemaVisitor for SchemaToAvroSchema {
PrimitiveType::TimestampNs => AvroSchema::TimestampNanos,
PrimitiveType::TimestamptzNs => AvroSchema::TimestampNanos,
PrimitiveType::String => AvroSchema::String,
- PrimitiveType::Uuid => AvroSchema::Uuid,
- PrimitiveType::Fixed(len) => avro_fixed_schema((*len) as usize)?,
+ PrimitiveType::Uuid => AvroSchema::Uuid(UuidSchema::String),
Review Comment:
> I'd either emit `UuidSchema::Fixed` (name `uuid_fixed`, size 16, same
define-once handling) or call the choice out explicitly.
Writing the spec's form changes the bytes that iceberg-rust writes, and this
PR keeps written manifests unchanged. #3262 lists the writer change as a
follow-up that needs a compatibility check, and it overlaps #2913 and #2916.
Writing a uuid partition fails today (#2913), and the description's "Behavior
changes" section says so. Would you be OK leaving the writer change to that
follow-up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
