danielcweeks commented on code in PR #17912:
URL: https://github.com/apache/iceberg/pull/17912#discussion_r4197678649
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -461,7 +462,12 @@ private void refreshStorageCredentials() {
return;
}
- try (VendedCredentialsProvider provider =
VendedCredentialsProvider.create(properties)) {
+ Map<String, String> refreshProperties = Maps.newHashMap(properties);
+ refreshProperties.putIfAbsent(
+ VendedCredentialsProvider.URI,
+ properties.get(AwsClientProperties.REFRESH_CREDENTIALS_ENDPOINT));
Review Comment:
I'm not sure why this is a cloud property specific field. It seems like
this should be the same for all IO implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
