linhongyu510 commented on code in PR #3145:
URL: https://github.com/apache/iceberg-rust/pull/3145#discussion_r4196914349
##########
crates/iceberg/src/arrow/caching_delete_file_loader.rs:
##########
@@ -334,10 +334,9 @@ impl CachingDeleteFileLoader {
/// Validates a deletion-vector task and returns what the read needs as
typed values:
/// `(start, len, referenced data file path, expected cardinality)`.
///
- /// The spec requires `referenced_data_file`, `content_offset` and
`content_size_in_bytes` on
- /// a deletion vector, and a deletion vector is always built from a
manifest entry, so it
- /// always carries `record_count`. A missing one is a manifest-entry
inconsistency rather
- /// than an I/O failure.
+ /// Builder-created tasks are validated up front, but deserialized scan
plans can bypass the
Review Comment:
You're right: deserialization now goes through the mirror and `build()`, so
that comment was stale. Fixed in `66d3d96b7`: the comment now describes
extracting the optional fields into the values needed for the byte-range read.
The fallible extraction remains; this follow-up changes comments only.
`cargo fmt --all -- --check` and `git diff --check` pass, and I checked that
every non-comment line is unchanged. I did not rerun the test suite for this
documentation-only change. Prepared with AI assistance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
