Sruhvx-jpg commented on PR #3288: URL: https://github.com/apache/iceberg-rust/pull/3288#issuecomment-6014131348
Pushed a commit addressing the remaining review hygiene items. This drops the unused `anyhow` dev-dependency and explicitly declares the required `tokio` features (`io-util`, `macros`, `net`, `rt-multi-thread`, `time`) in `crates/storage/common/Cargo.toml`. It also removes the duplicated `roundtrip_file_io` helper in `resolving_suite.rs` in favor of the shared import with `?` error propagation throughout, and scopes `ICEBERG_REQUIRE_STORAGE=1` directly to the `test: docker-up` recipe in the `Makefile`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
