ggershinsky commented on code in PR #18220:
URL: https://github.com/apache/iceberg/pull/18220#discussion_r4192184403
##########
docs/docs/encryption.md:
##########
@@ -24,7 +24,7 @@ Iceberg table encryption protects confidentiality and
integrity of table data in
The `metadata.json` file does not contain data or stats, and is therefore not
encrypted.
-Currently, encryption is supported in the Hive and REST catalogs for tables
with Parquet and Avro data formats.
+Currently, encryption is supported in the Hive, Glue and REST catalogs for
tables with Parquet and Avro data formats.
Review Comment:
can you also remove REST from this list, as its PR is not merged yet.
##########
spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/sql/TestTableEncryption.java:
##########
@@ -285,7 +285,7 @@ public void testMetadataTamperproofing() throws IOException
{
assertThatThrownBy(() -> catalog.loadTable(tableIdent))
.hasMessageContaining(
String.format(
- "The current metadata file %s might have been modified. Hash
of metadata loaded from storage differs from HMS-stored metadata hash.",
Review Comment:
These unitests run only with a Hive catalog, so the message seems to be ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
