szehon-ho commented on code in PR #18057: URL: https://github.com/apache/iceberg/pull/18057#discussion_r4190557364
########## format/udf-spec.md: ########## @@ -107,7 +107,12 @@ Notes: Types are based on the [Iceberg Type](https://iceberg.apache.org/spec/#schemas-and-data-types). Primitive and semi-structured type strings are encoded based on [Iceberg Type JSON Representation][iceberg-type-json] -(e.g., `int`, `string`, `timestamp`, `decimal(9,2)`, `variant`). Type strings must contain no spaces or quote characters. +(e.g., `int`, `string`, `timestamp`, `decimal(9, 2)`, `variant`). Type strings must contain no quote characters. + +[Appendix C][iceberg-type-json] permits both `decimal(9,2)` and `decimal(9, 2)`, so readers should accept optional Review Comment: It seems awkward for Appendix C to start wth the example, we should just focus on the rule ? ``` Readers should accept optional whitespace around parameters and separators in parameterized type strings, as described in [Appendix C](https://iceberg.apache.org/spec/#appendix-c-json-serialization). Such whitespace must not affect type equality. However, whitespace within parameter values, such as the space in the CRS value for geometry(srid: 3857), is significant and must be preserved. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
