rambleraptor opened a new pull request, #4081: URL: https://github.com/apache/iceberg-python/pull/4081
# Rationale for this change As part of #818, this adds `rename_view` support to the Iceberg REST Catalog. This is a revival of #2149, which was closed as stale. It's been rebased onto `main` and addresses the outstanding review comments from that PR: - Checks the `V1_RENAME_VIEW` endpoint capability - Raises `NoSuchNamespaceError` if the source or destination namespace doesn't exist, per the spec - Maps 409 to `ViewAlreadyExistsError` - Uses `_split_identifier_for_json`, and only splits each identifier once - Adds `@override` to the new `rename_view` implementations (and restores it on `BigQueryMetastoreCatalog.load_namespace_properties`) - Adds integration tests, including a cross-namespace rename The [REST Catalog spec](https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml) says neither `rename_view` nor `rename_table` returns anything. `rename_view` returns `None`. `rename_table` currently returns the `Table`, and changing that would be a breaking change, so it's left for the v1.0 breaking-changes discussion. # Are these changes tested? Yes. Unit tests in `tests/catalog/test_rest.py` and integration tests in `tests/integration/test_catalog.py`. # Are there any user-facing changes? - Added `rename_view` support to the Iceberg REST Catalog. cc @ebyhr @kevinjqliu @abnobdoss @jayceslesar @nhuantho, who reviewed #2149 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
