unikdahal commented on PR #3329: URL: https://github.com/apache/iceberg-rust/pull/3329#issuecomment-6000654284
> One question on scope: Java's SortingPositionOnlyDeleteWriter also takes a DeleteGranularity (write.delete.granularity). With FILE, it writes a separate delete file per data file, so every output is file-scoped; with PARTITION, it packs them the way this writer does. Since this is part of #3287 (file-scoped position deletes), and the by-path index in #2936 only helps for file-scoped files, is FILE granularity planned here or in a follow-up? Good point. Right now the granularity policy is intentionally left to the caller: one writer per data file gives FILE-style output, while one per partition gives the current PARTITION-style behavior. I’d prefer not to add "DeleteGranularity" to this low-level writer in this PR and if we want the crate to own that routing too, will raise a follow up to track it separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
