tomron opened a new pull request, #4077: URL: https://github.com/apache/iceberg-python/pull/4077
Closes #4076 # Rationale for this change `rest.client.connection-timeout-ms` and `rest.client.socket-timeout-ms` are ignored when `rest.sigv4-enabled` is set. `SigV4Adapter` is mounted on the catalog URI, which is a longer prefix than the `http://`/`https://` timeout adapter, so `requests` always picks it, and it never sets a timeout. `SigV4Adapter` now extends `_RetryTimeoutHTTPAdapter` and receives the same timeout, computed by a new shared helper `_connection_timeout()`. It keeps using `rest.sigv4.max-retries` for retries. The SigV4 retry behaviour (10 retries, no backoff) is unchanged and tracked in #3008. ## Are these changes tested? Yes, `test_sigv4_adapter_applies_client_timeout` in `tests/catalog/test_rest.py`. ## Are there any user-facing changes? Yes: the `rest.client.*` timeouts now take effect for SigV4-signed catalogs (e.g. S3 Tables, Glue REST). Documented in `configuration.md`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
