xanderbailey commented on code in PR #3066: URL: https://github.com/apache/iceberg-rust/pull/3066#discussion_r4183847186
########## crates/iceberg/src/spec/schema/mod.rs: ########## @@ -25,6 +25,9 @@ mod utils; mod visitor; pub use self::visitor::*; pub(super) mod _serde; +// TODO: Use for table replacement in https://github.com/apache/iceberg-rust/issues/3056. +#[allow(dead_code)] Review Comment: Tried this, but it breaks CI. In test builds the module isn't dead code (the tests in it use it), so the expectation goes unfulfilled: ``` error: this lint expectation is unfulfilled error: could not compile `iceberg` (lib test) due to 1 previous error ``` `make check-clippy` runs `cargo clippy --all-targets --all-features --workspace -- -D warnings`, and `--all-targets` includes the test target, so it's a hard failure rather than a warning. Sticking with `#[allow]` here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
