zeroshade commented on code in PR #2086:
URL: https://github.com/apache/iceberg-go/pull/2086#discussion_r4169573761
##########
table/maintenance/orphan_cleanup.go:
##########
@@ -95,32 +101,32 @@ const defaultPurgeMaxConcurrency = 32
type OrphanCleanupOption func(*orphanCleanupConfig)
-func WithLocation(location string) OrphanCleanupOption {
+func WithCleanupLocation(location string) OrphanCleanupOption {
Review Comment:
Optional nit: `OrphanCleanupOption` and the `WithCleanup*` options have no
doc comments. This rename fixes these names for v1, so please add one line each
with its default (table location, 72h, `false`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
