rdblue commented on code in PR #17541: URL: https://github.com/apache/iceberg/pull/17541#discussion_r4169469087
########## core/src/main/java/org/apache/iceberg/RootManifestFile.java: ########## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.nio.ByteBuffer; +import java.util.List; +import org.apache.iceberg.io.InputFile; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.util.ByteBuffers; + +/** A {@link ManifestFile} for the root manifest of an adaptive metadata tree. */ +class RootManifestFile implements ManifestFile { + private static final int FORMAT_VERSION = 4; + + private final InputFile file; + private final long snapshotId; + private final long sequenceNumber; + private final Long firstRowId; + private final byte[] keyMetadata; + private Long length = null; + + RootManifestFile( + InputFile file, + long snapshotId, + long sequenceNumber, + Long firstRowId, + ByteBuffer keyMetadata) { + Preconditions.checkArgument(file != null, "Invalid file: null"); + this.file = file; + this.snapshotId = snapshotId; + this.sequenceNumber = sequenceNumber; + this.firstRowId = firstRowId; + this.keyMetadata = ByteBuffers.toByteArray(keyMetadata); + } + + @Override + public String path() { + return file.location(); + } + + @Override + public long length() { + if (length == null) { + this.length = file.getLength(); + } + + return length; + } + + @Override + public int partitionSpecId() { + throw new UnsupportedOperationException("Root manifest has no partition spec"); + } + + @Override + public ManifestContent content() { + return ManifestContent.DATA; + } + + @Override + public long sequenceNumber() { + return sequenceNumber; + } + + @Override + public long minSequenceNumber() { + throw new UnsupportedOperationException("Root manifest has no minimum sequence number"); + } + + @Override + public Long snapshotId() { + return snapshotId; + } + + @Override + public Integer addedFilesCount() { + throw new UnsupportedOperationException("Root manifest has no added files count"); + } + + @Override + public Long addedRowsCount() { + throw new UnsupportedOperationException("Root manifest has no added rows count"); + } + + @Override + public Integer existingFilesCount() { + throw new UnsupportedOperationException("Root manifest has no existing files count"); + } + + @Override + public Long existingRowsCount() { + throw new UnsupportedOperationException("Root manifest has no existing rows count"); + } + + @Override + public Integer deletedFilesCount() { + throw new UnsupportedOperationException("Root manifest has no deleted files count"); + } + + @Override + public Long deletedRowsCount() { + throw new UnsupportedOperationException("Root manifest has no deleted rows count"); + } + + @Override + public List<PartitionFieldSummary> partitions() { + throw new UnsupportedOperationException("Root manifest has no partition summaries"); + } + + @Override + public ByteBuffer keyMetadata() { + return keyMetadata == null ? null : ByteBuffer.wrap(keyMetadata); + } + + @Override + public Long firstRowId() { + return firstRowId; + } + + @Override + public int formatVersion() { + return FORMAT_VERSION; + } + + @Override + public ManifestFile copy() { + ByteBuffer keyMetadataCopy = keyMetadata == null ? null : ByteBuffer.wrap(keyMetadata.clone()); Review Comment: We typically use `Arrays.copyOf` instead of `clone()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
