alessandro-nori opened a new pull request, #2103: URL: https://github.com/apache/iceberg-go/pull/2103
## Changes - replace fatal `require` assertions in `rest_test.go` HTTP handler goroutines with non-fatal assertions - return from handlers immediately after assertion failures - cover all 78 fatal handler assertions in the file - extend special-character request coverage to create, register, commit, and update table writes ## Motivation Fatal assertions call `FailNow` and `runtime.Goexit`. When invoked from an `httptest` handler goroutine, they terminate the handler rather than the test goroutine, often leaving a partial response and surfacing a misleading transport EOF instead of the original assertion failure. The expanded request test also pins that `a b+c` remains raw in JSON bodies while object-name path segments are encoded as `a%20b%2Bc`, addressing follow-up feedback from #2074. This PR is stacked on #2074. Its diff will shrink to the two follow-up commits after #2074 merges. ## Testing - `go test ./catalog/rest` - `go test ./catalog/...` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
