zeroshade commented on code in PR #2057:
URL: https://github.com/apache/iceberg-go/pull/2057#discussion_r4168186896
##########
table/snapshot_producers.go:
##########
@@ -543,6 +567,12 @@ func (m *manifestMergeManager) createManifest(specID int,
bin []iceberg.Manifest
}
}
+ // Java's merge manager writes zero-count manifests; this path omits
bins
+ // with no live entries.
Review Comment:
Nit: "no live entries" isn't quite the condition. A bin holding only deletes
from *this* snapshot is still written. A bin is dropped only when all of its
entries are deletes from earlier snapshots:
```suggestion
// whose entries are all deletes from earlier snapshots.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
