anoopj commented on code in PR #18108:
URL: https://github.com/apache/iceberg/pull/18108#discussion_r4161550752
##########
core/src/test/java/org/apache/iceberg/TestV4ManifestReader.java:
##########
@@ -1548,7 +1619,10 @@ public void
partitionFilterKeepsFileWithUnknownSpec(FileFormat format) throws IO
TrackedFile actual = readOne(builder);
- assertThat(actual).usingComparator(FILE_COMPARATOR).isEqualTo(file);
+ assertThat(actual.location()).isEqualTo(file.location());
+ assertThat(actual.partition())
+ .as("unknown spec's partition cannot be projected to its output type")
+ .isNull();
Review Comment:
Done. The test now asserts the file is returned and that `partition()`
throws `ValidationException` instead of returning null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
