amogh-jahagirdar commented on code in PR #16025: URL: https://github.com/apache/iceberg/pull/16025#discussion_r4160870180
########## format/spec.md: ########## @@ -1387,6 +1530,20 @@ At most one deletion vector is allowed per data file in a snapshot. If a DV is w [puffin-spec]: https://iceberg.apache.org/puffin-spec/ +#### Manifest Deletion Vectors + +A manifest deletion vector marks entries in a leaf manifest as deleted or replaced by encoding their positions in a bitmap. A set bit at position P indicates that the entry at position P in the referenced leaf manifest is deleted or replaced. + +Manifest deletion vectors are encoded using the [Mumbling bitmap spec][mumbling-spec] and stored inline on the root manifest entry that references the leaf manifest. The snapshot in which the vector last changed is recorded in `tracking.dv_snapshot_id`; the three bitmaps are: + +* `manifest_info.dv`: every position not live as of that snapshot. Review Comment: Hm. I meant "that snapshot" to refer to the dv_snapshot_Id, but that's not accurate for the cumulative manifest DV. Let me reword this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
