szehon-ho commented on code in PR #18255:
URL: https://github.com/apache/iceberg/pull/18255#discussion_r4160835866
##########
spark/v4.2/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ExtendedDataSourceV2Strategy.scala:
##########
@@ -189,6 +185,24 @@ case class ExtendedDataSourceV2Strategy(spark:
SparkSession) extends Strategy wi
case _ => Nil
}
+ private def resolveViewRenameTarget(
+ sourceCatalog: ViewCatalog,
+ targetName: Seq[String]): Identifier = {
+ if (targetName.length == 1) {
+ // An unqualified target renames in place, matching Spark's v2
RenameTableExec. Resolving it
Review Comment:
I'd remove the bug explanation here, as it doesnt seem relevant? Or keep it
minuimalistic, like why mention Spark3Util if not used.
Also do we need to add some info to the Spark3Util javadoc (if it makes
sense)? It seems a better place if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
