amogh-jahagirdar commented on code in PR #16025: URL: https://github.com/apache/iceberg/pull/16025#discussion_r4160428622
########## format/spec.md: ########## @@ -144,8 +147,11 @@ Version 4 of the Iceberg spec adds support for relative locations in metadata, e * **Schema** -- Names and types of fields in a table. * **Partition spec** -- A definition of how partition values are derived from data fields. * **Snapshot** -- The state of a table at some point in time, including the set of all data files. -* **Manifest list** -- A file that lists manifest files; one per snapshot. -* **Manifest** -- A file that lists data or delete files; a subset of a snapshot. +* **Snapshot root** -- The per-snapshot file that tracks a snapshot's manifests; a manifest list (v1-v3) or a root manifest (v4). Review Comment: Yeah this one is tricky to word because on the one hand the snapshot root in v4 can track more than just manifests, but at the same time "snapshot's metadata" is a bit too generic (snapshot metadata like timestamp etc are in non-content metadata). How about just snapshot's "files"? It works for all cases, it's just in v1-v3 there's restrictions on what those "files" can be. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
