szehon-ho commented on code in PR #17318:
URL: https://github.com/apache/iceberg/pull/17318#discussion_r4160311847
##########
format/spec.md:
##########
@@ -2069,38 +2069,38 @@ Snapshot summary can include metrics fields to track
numeric stats of the snapsh
#### Metrics
-| Field | Description
|
-|-------------------------------------|--------------------------------------------------------------------------------------------------|
-| **`added-data-files`** | Number of data files added in the
snapshot |
-| **`deleted-data-files`** | Number of data files deleted in the
snapshot |
-| **`total-data-files`** | Total number of live data files in the
snapshot |
-| **`added-delete-files`** | Number of positional/equality delete
files and deletion vectors added in the snapshot |
-| **`added-equality-delete-files`** | Number of equality delete files added
in the snapshot |
-| **`removed-equality-delete-files`** | Number of equality delete files
removed in the snapshot |
-| **`added-position-delete-files`** | Number of position delete files added
in the snapshot |
-| **`removed-position-delete-files`** | Number of position delete files
removed in the snapshot |
-| **`added-dvs`** | Number of deletion vectors added in
the snapshot |
-| **`removed-dvs`** | Number of deletion vectors removed in
the snapshot |
-| **`removed-delete-files`** | Number of positional/equality delete
files and deletion vectors removed in the snapshot |
-| **`total-delete-files`** | Total number of live
positional/equality delete files and deletion vectors in the snapshot |
-| **`added-records`** | Number of records added in the
snapshot |
-| **`deleted-records`** | Number of records deleted in the
snapshot |
-| **`total-records`** | Total number of records in the
snapshot |
-| **`added-files-size`** | The size of files added in the
snapshot |
-| **`removed-files-size`** | The size of files removed in the
snapshot |
-| **`total-files-size`** | Total size of live files in the
snapshot |
-| **`added-position-deletes`** | Number of position delete records
added in the snapshot |
-| **`removed-position-deletes`** | Number of position delete records
removed in the snapshot |
-| **`total-position-deletes`** | Total number of position delete
records in the snapshot |
-| **`added-equality-deletes`** | Number of equality delete records
added in the snapshot |
-| **`removed-equality-deletes`** | Number of equality delete records
removed in the snapshot |
-| **`total-equality-deletes`** | Total number of equality delete
records in the snapshot |
-| **`deleted-duplicate-files`** | Number of duplicate files deleted
(duplicates are files recorded more than once in the manifest) |
-| **`changed-partition-count`** | Number of partitions with files added
or removed in the snapshot |
-| **`manifests-created`** | Number of manifest files created in
the snapshot |
-| **`manifests-kept`** | Number of manifest files kept in the
snapshot |
-| **`manifests-replaced`** | Number of manifest files replaced in
the snapshot |
-| **`entries-processed`** | Number of manifest entries processed
in the snapshot |
+| Field | Description
|
+|-------------------------------------|--------------------------------------------------------------------------------------------------------------|
+| **`added-data-files`** | Number of data files added in the
snapshot |
+| **`deleted-data-files`** | Number of data files deleted in the
snapshot |
+| **`total-data-files`** | Total number of live data files in the
snapshot |
+| **`added-delete-files`** | Number of positional/equality delete
files and deletion vectors added in the snapshot |
+| **`added-equality-delete-files`** | Number of equality delete files added
in the snapshot |
+| **`removed-equality-delete-files`** | Number of equality delete files
removed in the snapshot |
+| **`added-position-delete-files`** | Number of position delete files added
in the snapshot |
+| **`removed-position-delete-files`** | Number of position delete files
removed in the snapshot |
+| **`added-dvs`** | Number of deletion vectors added in
the snapshot |
+| **`removed-dvs`** | Number of deletion vectors removed in
the snapshot |
+| **`removed-delete-files`** | Number of positional/equality delete
files and deletion vectors removed in the snapshot |
+| **`total-delete-files`** | Total number of live
positional/equality delete files and deletion vectors in the snapshot
|
+| **`added-records`** | Number of records added in the
snapshot |
+| **`deleted-records`** | Number of records deleted in the
snapshot |
+| **`total-records`** | Total number of records in the
snapshot (does not account for position/equality deletes or deletion vectors) |
Review Comment:
Could we keep “in live data files” here? It makes explicit that removed
files are excluded, while deleted rows still present in live files count toward
the total.
Suggested wording:
> Total number of records in live data files in the snapshot, before
applying position deletes, equality deletes, or deletion vectors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
