anoopj commented on code in PR #17541: URL: https://github.com/apache/iceberg/pull/17541#discussion_r4158283216
########## core/src/main/java/org/apache/iceberg/FilePlanner.java: ########## @@ -0,0 +1,208 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.io.IOException; +import java.io.UncheckedIOException; +import java.util.List; +import java.util.Map; +import java.util.concurrent.ExecutorService; +import org.apache.iceberg.expressions.Expression; +import org.apache.iceberg.expressions.Expressions; +import org.apache.iceberg.expressions.ResidualEvaluator; +import org.apache.iceberg.io.CloseableIterable; +import org.apache.iceberg.io.FileIO; +import org.apache.iceberg.metrics.ScanMetrics; +import org.apache.iceberg.metrics.ScanMetricsUtil; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; +import org.apache.iceberg.relocated.com.google.common.collect.Maps; +import org.apache.iceberg.util.ParallelIterable; +import org.apache.iceberg.util.ThreadPools; + +/** + * Plans {@link FileScanTask}s from a V4 root manifest. + * + * <p>Emits a task for each live {@code DATA} entry and expands {@code DATA_MANIFEST} entries into + * their leaf manifests. A data file's colocated deletion vector is attached to its task as a {@link + * DeleteFile}. + */ +class FilePlanner { + private static final DeleteFile[] NO_DELETES = new DeleteFile[0]; + + private final FileIO io; + private final ManifestFile root; + private final Schema tableSchema; + private final Map<Integer, PartitionSpec> specsById; + private final Map<Integer, TaskContext> taskContextsBySpec = Maps.newConcurrentMap(); + + private String tableLocation = null; + private Expression dataFilter = Expressions.alwaysTrue(); + private boolean ignoreResiduals = false; + private boolean caseSensitive = true; + private ScanMetrics scanMetrics = ScanMetrics.noop(); + private ExecutorService executorService = ThreadPools.getWorkerPool(); + + FilePlanner( + FileIO io, ManifestFile root, Schema tableSchema, Map<Integer, PartitionSpec> specsById) { + Preconditions.checkArgument(io != null, "Invalid file IO: null"); + Preconditions.checkArgument(root != null, "Invalid root manifest: null"); + Preconditions.checkArgument(tableSchema != null, "Invalid table schema: null"); + Preconditions.checkArgument(specsById != null, "Invalid specs by ID: null"); + this.io = io; + this.root = root; + this.tableSchema = tableSchema; + this.specsById = ImmutableMap.copyOf(specsById); + } + + FilePlanner tableLocation(String newTableLocation) { + Preconditions.checkArgument(newTableLocation != null, "Invalid table location: null"); + this.tableLocation = newTableLocation; + return this; + } + + FilePlanner filterData(Expression expr) { + Preconditions.checkArgument(expr != null, "Invalid filter: null"); + this.dataFilter = expr; + return this; + } + + FilePlanner ignoreResiduals() { + this.ignoreResiduals = true; + return this; + } + + FilePlanner caseSensitive(boolean newCaseSensitive) { + this.caseSensitive = newCaseSensitive; + return this; + } + + FilePlanner scanMetrics(ScanMetrics newScanMetrics) { + Preconditions.checkArgument(newScanMetrics != null, "Invalid scan metrics: null"); + this.scanMetrics = newScanMetrics; + return this; + } + + FilePlanner planWith(ExecutorService newExecutorService) { + Preconditions.checkArgument(newExecutorService != null, "Invalid executor service: null"); + this.executorService = newExecutorService; + return this; + } + + CloseableIterable<FileScanTask> planFiles() { + List<DataFile> rootDataFiles = Lists.newArrayList(); + List<ManifestFile> leafManifests = Lists.newArrayList(); + + try (CloseableIterable<TrackedFile> rootEntries = reader(root)) { + for (TrackedFile entry : rootEntries) { + switch (entry.contentType()) { + case DATA: + rootDataFiles.add(TrackedFileAdapters.asDataFile(entry, specsById)); + break; + case DATA_MANIFEST: + leafManifests.add(TrackedFileAdapters.asManifestFile(entry)); + break; + case DELETE_MANIFEST: + throw new UnsupportedOperationException("v3 and earlier deletes are not yet supported"); + default: + throw new UnsupportedOperationException( + "Unsupported file type in root manifest: " + entry.contentType()); + } + } + } catch (IOException e) { + throw new UncheckedIOException("Failed to close root manifest: " + root.path(), e); + } + + List<CloseableIterable<TrackedFile>> leafPlanTasks = Lists.newArrayList(); + for (ManifestFile leaf : leafManifests) { + leafPlanTasks.add(reader(leaf)); + } + + CloseableIterable<TrackedFile> leafFiles = + leafManifests.size() > 1 Review Comment: I see. My mental model was to model tests close to the default behavior of the code, which is to do parallel planning. Changed such that null executor is allowed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
