mxm commented on code in PR #17901: URL: https://github.com/apache/iceberg/pull/17901#discussion_r4155439525
########## flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/sink/MaxCommittedCheckpointIdValidator.java: ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.flink.sink; + +import java.util.Map; +import org.apache.flink.annotation.Internal; +import org.apache.iceberg.Snapshot; +import org.apache.iceberg.SnapshotAncestryValidator; +import org.apache.iceberg.exceptions.ValidationException; + +/** + * Validates, inside the commit transaction, that the branch does not already contain a commit for + * the staged checkpoint. This closes the race window between the up-front {@link + * SinkUtil#getMaxCommittedCheckpointId} read and the commit itself: if a previous commit attempt + * for the same checkpoint reached the catalog after the committer gave up (e.g. a client timeout on + * a slow catalog commit) and the commit request is redelivered on recovery, the refreshed base + * ancestry already contains a snapshot whose max-committed-checkpoint-id is >= the staged + * checkpoint, and the commit is rejected rather than duplicating the checkpoint's data. + * + * <p>Shared by both the non-dynamic {@link IcebergCommitter} and the {@code DynamicCommitter}. + */ +@Internal +public class MaxCommittedCheckpointIdValidator implements SnapshotAncestryValidator { Review Comment: Could we move this class to `SinkUtil`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
