Benjamin0313 commented on PR #16665: URL: https://github.com/apache/iceberg/pull/16665#issuecomment-5923068159
Thanks @dvaldivia for the ping and @manuzhang for reopening — sorry for letting this slip. I'll resolve the merge conflicts with main. Since Spark 4.2 is now the default, should I move this to spark/v4.2 (or cover both 4.1 and 4.2)? @manuzhang Both findings from your last review are addressed: - bucket(time): added BucketTime, which converts nanos to micros before hashing. It's a separate class because codegen calls the static invoke on the bound class (ccee16d). - Equality deletes on time: the vectorization gate now also checks equality-delete fields, including dropped columns via historic schemas (ccee16d, df5b2d6, 2fe907d). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
