rambleraptor commented on code in PR #2076:
URL: https://github.com/apache/iceberg-go/pull/2076#discussion_r4149217879
##########
schema.go:
##########
@@ -1486,15 +1486,29 @@ func buildAccessors(schema *Schema) (map[int]accessor,
error) {
type setFreshIDs struct {
oldIdToNew map[int]int
nextIDFunc func() int
+ visiting *Schema
Review Comment:
Fine with me (very unoppinionated on naming)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
