NoahKusaba commented on code in PR #2904:
URL: https://github.com/apache/iceberg-rust/pull/2904#discussion_r4144417687
##########
crates/iceberg/src/scan/mod.rs:
##########
@@ -1963,6 +1968,108 @@ pub mod tests {
);
}
+ /// `table` with a column added after its last write, so its current
schema is
+ /// ahead of the schema its current snapshot was written with.
+ fn with_column_added_after_last_write(table: &Table) -> Table {
Review Comment:
Done in fdefe7ef8. The helper now takes a closure over the schema's fields,
and each case you tried is a test that reads the fixture's data files and
asserts the full result:
- Drop and re-add `dbl` with a new field ID: all 2048 values are null;
pinned to the snapshot, the old values come back.
(`test_scan_of_current_state_reads_null_for_column_readded_after_last_write`)
- Rename to `dbl2`: the values come back under the new name.
(`..._reads_column_renamed_after_last_write`)
- Drop `dbl`: a current-state scan fails with the full error; pinned, all
2048 values still read. (`..._excludes_column_dropped_after_last_write`)
- Filter on the added column: `is_null` returns every row, `equal_to(1)`
none. (`..._filters_on_column_added_after_last_write`)
Reverting the fix fails all four.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
