pvary commented on PR #17774: URL: https://github.com/apache/iceberg/pull/17774#issuecomment-5894111454
Mostly looks good to me, but please review the javadoc based on the guidelines described in the new AGENTS.md on the main branch. Also simplify or provide a summary in the PR description so people don't have to spend too much time reading everything. Check the test methods too. I'm not sure that `interleaveRaggedColumns` adds to much value, but correct me if I'm wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
