Copilot commented on code in PR #18301: URL: https://github.com/apache/iceberg/pull/18301#discussion_r4129115618
########## format/spec.md: ########## @@ -110,11 +110,13 @@ Inheriting the sequence number from manifest metadata allows writing a new manif Row-level deletes are stored in delete files. -There are two types of row-level deletes: +The current representation is [_deletion vectors_](#deletion-vectors) (v3 or above), which encode deleted positions of a single data file in a bitmap. -* **Position deletes** -- Mark a row deleted by data file path and the row position in the data file. Position deletes are encoded in a [_position delete file_](#position-delete-files) (V2) or [_deletion vector_](#deletion-vectors) (V3 or above). +Legacy representations: -* **Equality deletes** -- Mark a row deleted by one or more column values, like id = 5. Equality deletes are encoded in [_equality delete file_](#equality-delete-files) (may be created in v2 and v3 tables only). +* **Position deletes** -- Mark a row deleted by data file path and the row position in the data file. Position deletes are encoded in a [_position delete file_](#position-delete-files), which may be created in v2 tables only. + +* **Equality deletes** -- Mark a row deleted by one or more column values, like id = 5. Equality deletes are encoded in an [_equality delete file_](#equality-delete-files), which may be created in v2 and v3 tables only. Review Comment: The legacy representation is the *position delete file*, not the position-delete concept itself: deletion vectors also represent deletes by row position. Labeling “Position deletes” as legacy makes the overview conflict with the preceding description of DVs and can mislead implementers into treating positional deletion as v2-only. Name both bullets after the file representations instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
