uros-b commented on issue #17959: URL: https://github.com/apache/iceberg/issues/17959#issuecomment-5876440272
> Also add tests for existing behavior: > - DSv2 cache invalidation and refresh (spark#55416, spark#55536) For https://github.com/apache/spark/pull/55536 (SPARK-54022 / SPARK-56617, DSv2 CACHE TABLE read semantics), it is already mirrored in TestCachedTableRefresh from the 4.1 -> 4.2 work. One scenario (a session ALTER TABLE invalidating the cache) was `@Disabled` pending SPARK-55631, which is fixed in 4.2.0, so #18298 re-enables it (now green under both the SparkCatalog and SparkSessionCatalog configs). For https://github.com/apache/spark/pull/55416 (SPARK-54216, cache refresh with immutable Table instances), this PR was closed without merging and its JIRA is still open. The behavior looks already exercised by testCachedTableRefreshReflectsExternalChanges under the caching-catalog config, so I left it out; but I would be happy to add dedicated tests mirroring it if folks think that additional coverage is worth having. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
