moggaa commented on code in PR #17653:
URL: https://github.com/apache/iceberg/pull/17653#discussion_r4121943463
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/RecordConverter.java:
##########
@@ -259,7 +259,7 @@ private GenericRecord convertToStruct(
hasSchemaUpdates = true;
}
}
- Object recordFieldValue = struct.get(recordField);
+ Object recordFieldValue = fieldValue(struct, recordField);
Review Comment:
Done in 80a52256e — `MongoDebeziumTransform` now uses `getWithoutDefault` in
its envelope copy loop, with a test (its `updateDescription` metadata reads
stay as-is, matching how `DebeziumTransform` reads its own envelope fields).
The migration note is in d585a0d49: the bundled SMTs always preserve explicit
nulls regardless of the sink option, and the copied schema retains the field
defaults, so consumers that substitute defaults on read see the same values as
before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
