nssalian opened a new pull request, #2066: URL: https://github.com/apache/iceberg-go/pull/2066
Relates to the v1 cleanup effort (#2062). ### Changes Moves the shared namespace-property helper `getUpdatedPropsAndUpdateSummary` (and `checkForOverlap`) from the root `catalog` package into `catalog/internal`, and drops the `//go:linkname` hack plus `import _ "unsafe"` from the Glue, Hive, and SQL backends. The linkname existed to avoid an import cycle while keeping the helper unexported. That no longer applies: `catalog/internal` already imports `catalog`, so the helper can live there, return `catalog.PropertiesUpdateSummary` directly, and be called normally by the backends (which already import `catalog/internal`). Logic is moved verbatim - no behavior change. Internal-only refactor; no exported `catalog` symbol changes. `//go:linkname` is fragile: it breaks silently if the target signature changes, is invisible to normal tooling, and needs a `//lint:ignore` to satisfy staticcheck. Removing it is a maintainability win on its own. ### Testing Verified locally: `go build ./...` and `go vet ./catalog/...` pass; `go test ./catalog/internal/` passes; `golangci-lint run ./catalog/...` reports no findings in the changed files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
