plusplusjiajia opened a new pull request, #966: URL: https://github.com/apache/iceberg-cpp/pull/966
Follow-up to https://github.com/apache/iceberg-cpp/pull/898#discussion_r4091927837. `ArrowS3FileIO::DeleteFiles` returned at the first credential prefix whose delete failed, so files under the remaining prefixes were never attempted. Java's `S3FileIO.deleteFiles` attempts every batch, logs each failed path, and throws `BulkDeletionFailureException` with the count. This deletes each file through its delegate, logs every failure, and returns `Failed to delete N of M files`. The requests are unchanged: Arrow's S3 `DeleteFiles` also deletes one file at a time. `ResolvingFileIO` stays fail-fast across delegates, as Java's does. `DeleteFilesAttemptsEveryFile` puts an allowed file between two denied ones; it fails on `main` and passes here. This touches the same function as #898, so whichever lands second needs a small rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
